Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwargs widget should be initialized with parameter #1360

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

okz
Copy link
Contributor

@okz okz commented Sep 12, 2023

@martindurant
Copy link
Member

Would you like to write a test for this? It would involve making an instance with a value, and then asserting that the GUI's filesystem instance attribute has the right option set. A good candidate would be '{"auto_mkdir": True}' with the "file" protocol, which sets the auto_mkdir attribute on the instance (and is False by default).

@okz
Copy link
Contributor Author

okz commented Sep 12, 2023

ah didn't think of using a non authentication related kwarg.. test added.

@martindurant
Copy link
Member

(please runt he precommit hooks for linting - you are getting a little formatting edits and trailing whitespace)

@martindurant martindurant merged commit d0b6f70 into fsspec:master Sep 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants